Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(flake.nix): install locales on linux host devShells #16120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix(flake.nix): install locales on linux host devShells #16120

merged 1 commit into from
Jan 15, 2025

Conversation

ThomasK33
Copy link
Member

@ThomasK33 ThomasK33 commented Jan 13, 2025 •
edited
Loading

Change-Id: I22dba63d317b41749c807a55e15278006cdcecad
Signed-off-by: Thomas Kosiewski [email protected]

  • Adds neovim and fzf to development tools, removes sapling, and fixes locale issues on Linux systems.
  • Updates Dockerfile.nix syntax to use uppercase AS to remove warnings.
  • Refactored conditional logic for strace inclusion using lib.optional.

@ThomasK33 Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ThomasK33 ThomasK33 marked this pull request as ready for review January 13, 2025 17:38
@ThomasK33 ThomasK33 requested a review from coadler January 13, 2025 17:39
@ThomasK33 ThomasK33 changed the title fix(flake.nix): Install locales on linux host devShells fix(flake.nix): install locales on linux host devShells Jan 13, 2025
@ThomasK33 ThomasK33 force-pushed the 01-13-fix_flake.nix_install_locales_on_linux_host_devshells branch from dcb002b to 1275610 Compare January 14, 2025 09:30
@ThomasK33
fix(flake.nix): Install locales on linux host devShells
304bbde 
Change-Id: I22dba63d317b41749c807a55e15278006cdcecad
Signed-off-by: Thomas Kosiewski <[email protected]>
@ThomasK33 ThomasK33 force-pushed the 01-13-fix_flake.nix_install_locales_on_linux_host_devshells branch from 1275610 to 304bbde Compare January 14, 2025 10:05
@ThomasK33 ThomasK33 merged commit e7f1081 into main Jan 15, 2025
29 checks passed
@ThomasK33 ThomasK33 deleted the 01-13-fix_flake.nix_install_locales_on_linux_host_devshells branch January 15, 2025 16:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

Assignees

@ThomasK33 ThomasK33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasK33 @coadler