Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(enterprise/coderd): use filesystem mirror for providers in TestWorkspaceTagsTerraform #16155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

johnstcn
Copy link
Member

Fixes coder/internal#266 (hopefully)

Each instance of this test has to download the coder/coder Terraform provider.
To mitigate this, only download the providers once using a filesystem_mirror (ref: https://developer.hashicorp.com/terraform/cli/config/config-file#provider-installation)

@johnstcn johnstcn self-assigned this Jan 15, 2025
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

// downloadProviders is a test helper that creates a temporary file and writes a
// terraform CLI config file with a provider_installation stanza for coder/coder
// using dev_overrides. It also fetches the latest provider release from GitHub
// and extracts the binary to the temporary dir. It is the responsibility of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the line length alignment here 😍, too bad about the third line missing one char 🤣

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that specifically to annoy you ;-P

@johnstcn johnstcn changed the title chore(enterprise/coderd): TestWorkspaceTagsTerraform: use filesystem mirror for providers chore(enterprise/coderd): use filesystem mirror for providers in TestWorkspaceTagsTerraform Jan 15, 2025
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@johnstcn johnstcn merged commit 3a81aac into main Jan 15, 2025
35 checks passed
@johnstcn johnstcn deleted the cj/flake/testworkspacetagsterraform branch January 15, 2025 20:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake: TestWorkspaceTagsTerraform: context canceled
3 participants