-
Notifications
You must be signed in to change notification settings - Fork 881
test(cli): fix TestSSH/RemoteForward_Unix_Signal flake #16172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The re-use of net.Listener seemed dubious and potentially the cause of sometimes the second run failing with an empty message.
I'm not sure I follow: can you describe the mechanism you're worried about that could potentially cause the second run to fail with a n empty message? Is there an issue describing the flake this fixes? |
Anything that can result in an empty string being sent on The part that seems dubious to me is how we attempt to dial and send the message multiple times until
Alas no, ran into this locally and the output got lost after a clear screen. As I was writing this I managed to reproduce:
|
@spikecurtis since I can't spot anything wrong with not re-using the listener, I went ahead and merged this but if you see another cause for the flake or spot a problem with this approach happy to revert/amend. |
The re-use of net.Listener seemed dubious and potentially the cause of
sometimes the second run failing with an empty message.