Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test(coderd/autobuild): fix context initialization in tests #16173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jan 17, 2025

This is a bit of a gotcha in our tests, we should never pre-create contexts that time out. They should be created once needed so that the time it takes to do coderd operations/fixtures doesn't time it out.

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call 👍

@mafredri mafredri merged commit e693b66 into main Jan 17, 2025
35 checks passed
@mafredri mafredri deleted the mafredri/test-fix-coderd-autobuild-ctx branch January 17, 2025 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants