Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test(cli): fix context init in TestSupportBundle #16174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

test(cli): fix context init in TestSupportBundle #16174

merged 1 commit into from
Jan 17, 2025

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jan 17, 2025 •
edited
Loading

Saw this flake but I didn't discern the exact cause: https://github.com/coder/coder/actions/runs/12828659209/job/35773186400?pr=16170

So I fixed the contexts here just in case.

This was suspicious:

    t.go:106: 2025-01-17 12:06:10.009 [debu]  coderd.coord: peerReadLoop context done  peer_id=80ca93ed-5546-4698-920d-046008c5b74d  peer_name=client  request_id=b6fc52b2-538e-48fa-b50c-8e349eb74d48

And given the even round number of 30s here:

    t.go:106: 2025-01-17 12:06:39.926 [debu]  coderd: GET  host=localhost:51586  path=/api/v2/debug/health  proto=HTTP/1.1  remote_addr=127.0.0.1  start="2025-01-17T12:06:09.925865Z"  took=30.000337625s  status_code=404  latency_ms=30000  request_id=45adda5d-d9d8-4dc0-98b0-317b0ddf625a

@mafredri mafredri merged commit 860d17a into main Jan 17, 2025
47 checks passed
@mafredri mafredri deleted the mafredri/test-fix-cli-bundle branch January 17, 2025 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@johnstcn johnstcn johnstcn approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @dannykopping @johnstcn