Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(codersdk/healthsdk): update docs url path for health errors #16180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jan 17, 2025

Updates the URL suffix we append to DeploymentValues.DocsURL to generate stable links for health messages.
Adds missing test case coverage for custom docs URL from deployment values.

@johnstcn johnstcn requested a review from EdwardAngert January 17, 2025 17:18
@johnstcn johnstcn self-assigned this Jan 17, 2025
@johnstcn johnstcn requested a review from mafredri January 17, 2025 17:18
@EdwardAngert EdwardAngert changed the base branch from main to 2025-01-16-linkfix January 17, 2025 17:21
@johnstcn johnstcn force-pushed the cj/healthsdk/docs-url branch from 20b14b5 to 872dcde Compare January 17, 2025 17:26
@johnstcn johnstcn merged commit 55351f6 into 2025-01-16-linkfix Jan 17, 2025
23 of 32 checks passed
@johnstcn johnstcn deleted the cj/healthsdk/docs-url branch January 17, 2025 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
@matifali
Copy link
Member

/cherry-pick release/2.18

@johnstcn
Copy link
Member Author

/cherry-pick release/2.18

not this one!

@matifali
Copy link
Member

@johnstcn Oops. Let this be a test for the bot. I will close the PR the bot opens.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants