Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(flake.nix): switch dogfood dev image to buildNixShellImage from dockerTools #16223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2025
Merged

feat(flake.nix): switch dogfood dev image to buildNixShellImage from dockerTools #16223

merged 2 commits into from
Jan 28, 2025

Conversation

ThomasK33
Copy link
Member

@ThomasK33 ThomasK33 commented Jan 22, 2025 •
edited
Loading

Replace Depot build action with Nix for Nix dogfood image builds

The dogfood Nix image is now built using Nix's native container tooling instead of Depot. This change:

  • Adds Nix setup steps to the GitHub Actions workflow
  • Removes the Dockerfile.nix in favor of a Nix-native container build
  • Updates the flake.nix to support building Docker images
  • Introduces a hash file to track Nix-related changes
  • Updates the vendorHash for Go dependencies

Change-Id: I4e011fe3a19d9a1375fbfd5223c910e59d66a5d9
Signed-off-by: Thomas Kosiewski [email protected]

@ThomasK33 Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ThomasK33 ThomasK33 marked this pull request as ready for review January 22, 2025 10:34
@ThomasK33 ThomasK33 force-pushed the 01-22-feat_flake.nix_switch_dogfood_dev_image_to_buildnixshellimage_from_dockertools branch from 8226db4 to 32d3437 Compare January 22, 2025 10:57
dannykopping
dannykopping approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but my knowledge of nix is minimal so maybe get someone else to review that part
Thanks!

matifali
matifali approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few suggestions, but LGTM.
Not a nix expert, so I can not validate that part of the PR.

@matifali
Copy link
Member

Also .dockerignore may be unused now. It was perviously being used by docker build for nix image.

@ThomasK33 ThomasK33 force-pushed the 01-22-feat_flake.nix_switch_dogfood_dev_image_to_buildnixshellimage_from_dockertools branch 2 times, most recently from a11ecf6 to 56640ad Compare January 23, 2025 14:05
matifali
matifali reviewed Jan 23, 2025
View reviewed changes
matifali
matifali reviewed Jan 23, 2025
View reviewed changes
@ThomasK33 ThomasK33 requested a review from johnstcn January 24, 2025 10:04
@ThomasK33 ThomasK33 force-pushed the 01-22-feat_flake.nix_switch_dogfood_dev_image_to_buildnixshellimage_from_dockertools branch from 56640ad to c18c4ca Compare January 24, 2025 11:40
johnstcn
johnstcn reviewed Jan 24, 2025
View reviewed changes
johnstcn
johnstcn reviewed Jan 24, 2025
View reviewed changes
johnstcn
johnstcn approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from existing comments.

@ThomasK33 ThomasK33 force-pushed the 01-22-feat_flake.nix_switch_dogfood_dev_image_to_buildnixshellimage_from_dockertools branch 5 times, most recently from c1f3eaa to cb87bcf Compare January 27, 2025 18:22
@ThomasK33 ThomasK33 force-pushed the 01-22-feat_flake.nix_switch_dogfood_dev_image_to_buildnixshellimage_from_dockertools branch 3 times, most recently from d38027c to dafaf96 Compare January 28, 2025 14:34
@ThomasK33
feat(flake.nix): switch dogfood dev image to buildNixShellImage from …
24c36e2 
…dockerTools

Change-Id: I4e011fe3a19d9a1375fbfd5223c910e59d66a5d9
Signed-off-by: Thomas Kosiewski <[email protected]>
@ThomasK33
update gomock
0ed90c6 
Change-Id: Id4cb8943ae1bf40d0b24eb899bd58801f28e851a
Signed-off-by: Thomas Kosiewski <[email protected]>
@ThomasK33 ThomasK33 force-pushed the 01-22-feat_flake.nix_switch_dogfood_dev_image_to_buildnixshellimage_from_dockertools branch from dafaf96 to 0ed90c6 Compare January 28, 2025 14:57
@ThomasK33 ThomasK33 merged commit 1336925 into main Jan 28, 2025
38 checks passed
@ThomasK33 ThomasK33 deleted the 01-22-feat_flake.nix_switch_dogfood_dev_image_to_buildnixshellimage_from_dockertools branch January 28, 2025 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

@dannykopping dannykopping dannykopping approved these changes

@johnstcn johnstcn johnstcn approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis spikecurtis is a code owner

Assignees

@ThomasK33 ThomasK33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomasK33 @matifali @dannykopping @johnstcn