chore: add workspace reached resource threshold notification #16250
Conversation
|
@DanielleMaywood I had imagined these being separate notification toggles for disk and memory since they're hardcoded in the template. I realize this is a little late to make that change, would it be overly complex to separate these toggles? I fear that OOM alerts will be noisy compared to OOD. If the user has to choose both or neither, they may forfeit OOD to mute OOM. |
I'm happy to just have two separate notifications in this case. @defelmnq What are your thoughts? |
|
Chatted live, we'll separate these into two notifications. Copy looks good, I'd recommend a more pop-out header:
Then we can keep the more descriptive body as-is. |
coderd/database/migrations/000288_oom_and_ood_notification.up.sql
Outdated
Show resolved
Hide resolved
| Labels: map[string]string{ | ||
| "workspace": "bobby-workspace", | ||
| "threshold": "90%", | ||
| "volume": "/home/coder", |
There was a problem hiding this comment.
Can we only alert on one volume being above threshold at once?
There was a problem hiding this comment.
With how this template is written, yes.
There was a problem hiding this comment.
Can we refactor to accept a slice of volumes please?
As an end-user, I wouldn't find much value in receiving one notification for each volume. We already have memory and volume split which I understand is for practical reasons, but splitting volumes would just add noise.
There was a problem hiding this comment.
Have now done so, have updated the screenshots to show the update notification wording
coderd/database/migrations/000288_oom_and_ood_notification.up.sql
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,33 @@ | |||
| INSERT INTO notification_templates | |||
There was a problem hiding this comment.
Should we make these inactive by default? We'll be launching inbox (hopefully) soon after OOM/OOD drops, and duplication would be unfortunate.
There was a problem hiding this comment.
We could do, although I could be convinced to go either way on this.
There was a problem hiding this comment.
@stirby WDYT? I fairly feel strongly that SMTP alerts for these are low value, and webhook is unlikely to be the default method chosen most of the time.
There was a problem hiding this comment.
I'd prefer to leave these enabled for user visibility. I think more redundancy is preferred since these are pointing out an error that may lead to loss of work.
| }, | ||
| }, | ||
| { | ||
| name: "TemplateWorkspaceOutOfDisk", |
There was a problem hiding this comment.
Nit: same test name twice.
| name: "TemplateWorkspaceOutOfDisk", | |
| name: "TemplateWorkspaceOutOfDisk_MultipleVolumes", |
Good catch @defelmnq, will delete the unused ones. |
Closes coder/internal#247
User Notification Settings:
Admin Notification Settings:
Out Of Memory notification:
Out Of Disk notifications:
