Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: update IdP group and role sync documentation for UI configuration #16315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 31, 2025

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngert EdwardAngert commented Jan 28, 2025

closes coder/internal#277

to do:

  • deprecate server flag steps
  • bump down tab headings (remove from toc)
  • add dashboard steps for each

- [ ] re-org doc partially complete, but this will need revisiting

preview

@EdwardAngert EdwardAngert added the docs Area: coder.com/docs label Jan 28, 2025
@EdwardAngert EdwardAngert self-assigned this Jan 28, 2025
@EdwardAngert EdwardAngert changed the title docs: Update docs for IDP group and role sync to reflect the ability to configure in the UI docs: update IDP group and role sync documentation for UI configuration Jan 28, 2025
authenticates using OIDC, the application requests offline access to the user's
resources, including the ability to refresh access tokens without requiring the
user to reauthenticate.
The `access_type` parameter has two possible values: `online` and `offline`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried looking for more information about this and found https://registry.terraform.io/providers/mrparkers/keycloak/latest/docs/resources/openid_client

Based on that, there are other options and neither online nor offline are listed. Is this wording still accurate?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best revisiting this after merge too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are the wrong docs, it will not be a terraform resource.

I cannot find the correct docs though. This is the best I found
https://wjw465150.gitbooks.io/keycloak-documentation/content/server_admin/topics/sessions/offline.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find @Emyrk !

I found the source of that page, then traced it back to the keycloak docs - seems like it's the same info

glancing at their docs, the parameter is scope=offline_access and maybe not access_type, so it seems like it's still worth exploring our Keycloak section later

Clients can request an offline token by adding the parameter scope=offline_access when sending their authorization request to Keycloak.

that doc also links to https://openid.net/specs/openid-connect-core-1_0.html#OfflineAccess

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is worth explorig. The scope is different than the query param in the auth url.

The url param is defined in the OIDC spec https://developers.google.com/identity/openid-connect/openid-connect. Unsure if it is an oauth thing, or an oidc thing.

The oauth library we use has it defined:
https://github.com/golang/oauth2/blob/master/oauth2.go#L109-L121

As for what the scope does, I am unsure. It might be related to the query param, idk 🤷‍♂️.

Comment on lines 610 to 612
- `preferred_username`: You can use e.g. "Display Name" as required.
- `email`: You can use e.g. the LDAP attribute "E-Mail-Addresses" as
required.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these "Display Name" and "E-Mail-Addresses" values from somewhere? I'm trying to reword these points

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth cleaning up this section as a separate PR. Unsure who wrote it, we can use git blame

@EdwardAngert EdwardAngert changed the title docs: update IDP group and role sync documentation for UI configuration docs: update IdP group and role sync documentation for UI configuration Jan 29, 2025
@EdwardAngert EdwardAngert marked this pull request as ready for review January 30, 2025 05:41
Comment on lines 50 to 51
For deployments with multiple [organizations](./organizations.md), configure
group sync at the organization level.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even single org deployments have to configure it at the org level. They just configure it in the default org.

Copy link
Member

@bpmct bpmct Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaaydenh Do single org deployments on the Standard license see this UI?

Copy link
Contributor Author

@EdwardAngert EdwardAngert Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah:

2025-01-31_13-37-50

we're trying to remind people that if you have more than one, configure it in the appropriate org. Let me see if I can rework this a little

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just in case, here's a screenshot of people see if they don't have a premium license

2025-01-31_14-13-34

authenticates using OIDC, the application requests offline access to the user's
resources, including the ability to refresh access tokens without requiring the
user to reauthenticate.
The `access_type` parameter has two possible values: `online` and `offline`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are the wrong docs, it will not be a terraform resource.

I cannot find the correct docs though. This is the best I found
https://wjw465150.gitbooks.io/keycloak-documentation/content/server_admin/topics/sessions/offline.html

@EdwardAngert EdwardAngert requested a review from Emyrk January 31, 2025 19:40
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Edward :)

@EdwardAngert EdwardAngert enabled auto-merge (squash) January 31, 2025 20:34
@EdwardAngert EdwardAngert merged commit 92a490b into main Jan 31, 2025
28 checks passed
@EdwardAngert EdwardAngert deleted the 277-idp-sync-dash branch January 31, 2025 20:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs for IDP group and role sync to reflect the ability to configure in the UI
3 participants