chore: track the first time html is served in telemetry #16334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24b1f2a to
63246e8
Compare
dannykopping
approved these changes
Jan 30, 2025
cli/server_test.go
Outdated
|
|
||
| accessURL := waitAccessURL(t, cfg) | ||
|
|
||
| ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitMedium) |
There was a problem hiding this comment.
Nit:
Suggested change
| ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitMedium) | |
| ctx := testutil.Context(t, testutil.WaitMedium) |
coderd/telemetry/telemetry.go
Outdated
| @@ -1536,6 +1557,20 @@ type Organization struct { | |||
| CreatedAt time.Time `json:"created_at"` | |||
| } | |||
|
|
|||
| //revive:disable:exported | |||
| type TelemetryItemKey string | |||
There was a problem hiding this comment.
I don't see why this has to be exported; can you elaborate pls?
There was a problem hiding this comment.
Just a habit that when I export enum values, I export their type too. It's not strictly necessary here.
| // The purpose is to track the first time the first user opens the site. | ||
| func (h *Handler) reportHTMLFirstServedAt() { | ||
| // nolint:gocritic // Manipulating telemetry items is system-restricted. | ||
| ctx := dbauthz.AsSystemRestricted(context.Background()) |
There was a problem hiding this comment.
Please add a TODO to add a telemetry context in RBAC at some point.
site/site.go
Outdated
| @@ -183,6 +187,8 @@ type Handler struct { | |||
|
|
|||
| Entitlements *entitlements.Set | |||
| Experiments atomic.Pointer[codersdk.Experiments] | |||
|
|
|||
| TelemetryHTMLServedOnce sync.Once | |||
There was a problem hiding this comment.
Why is this exported?
There was a problem hiding this comment.
It doesn't need to be - thanks for catching it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/coder/nexus/issues/175.
Changes
telemetry_itemsdatabase table. It's a key value store for telemetry events that don't fit any other database tables.site.go.