feat: form for editing ws schedule #1634
Conversation
Summary: This presents a form component and storybook. The UI will be a routed page and added into the dashboard in a separate PR. It is likely a XService will be used at the page level to supply errors and actions to this form. Impact of Change: Further progress on #1455 Squashed Commits: * refactor: add className prop to Stack combine classes with internal classes and an optional external className to better control the Stack.
| control={<Checkbox checked={form.values.saturday} onChange={form.handleChange} name="saturday" />} | ||
| label={Language.daySaturdayLabel} | ||
| /> | ||
| </FormGroup> |
There was a problem hiding this comment.
Review: I can create a map for these as a refactor...will do in follow-up/later.
| initialValues: { | ||
| sunday: false, | ||
| monday: true, | ||
| tuesday: true, | ||
| wednesday: true, | ||
| thursday: true, | ||
| friday: true, | ||
| saturday: false, |
There was a problem hiding this comment.
(non-blocking): I'm not sure how this is going to be translated into a CRON string, but the below are all valid representations:
MON-FRI
MON,TUE,THU,SUN
1-3
2,3,4,5
There was a problem hiding this comment.
The parent controlling the form will map the startTime and each of these into an acceptable cron string.
It will likely do , format for simplicity. We will test each of these cases both with code and in crontab.guru.
However, this is all to say - that's a follow-up to the form, that doesn't need to know anything about cron. The code that maps between the form and API is dependency injected via onSubmit, which allows us to test and maintain it in isolation, should something about our cron format change (which is nice).
* feat: ui for editing ws schedule Summary: This presents a form component and storybook. The UI will be a routed page and added into the dashboard in a separate PR. It is likely a XService will be used at the page level to supply errors and actions to this form. Impact of Change: Further progress on #1455 Squashed Commits: * refactor: add className prop to Stack combine classes with internal classes and an optional external className to better control the Stack. * fix: getFormHelpers helperText the helperText logic was incorrect, the helperText would only show if not touched.
Summary:
This presents a form component and storybook. The UI will be a routed
page and added into the dashboard in a separate PR. It is likely a
XService will be used at the page level to supply errors and actions to
this form.
Impact of Change:
Further progress on #1455
Squashed Commits:
combine classes with internal classes and an optional external className
to better control the Stack.