ci: fix cla and dependabot notifications jobs #16343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
commented
Jan 30, 2025
| types: | ||
| - opened | ||
| - closed | ||
| - synchronize | ||
| - labeled | ||
| - unlabeled | ||
| - opened |
There was a problem hiding this comment.
removed the duplicate from L8
ethanndickson
approved these changes
Jan 31, 2025
Switch `release-labels` job trigger to `pull_request_target` and refine `dependabot` automerge conditions by verifying `actor_id`. Enhance logging for approval and merge steps to provide better visibility.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we merge a PR programmatically using
gh pr merge --auto --squash,the Github auto handles the merge after all checks are passed. So, apull_requestevent does not get triggered, and a merge commit is pushed tomainbygithub-actions[bot].This change handles that case.I also extracted all dependable logic to a separate workflow for better control and restored the original state of
contrib.yamlso that cla can work as expected for Community PRs.