Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: update PlatformX doc with steps from README #16406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngert EdwardAngert commented Feb 3, 2025

copied and reformatted the steps from the https://github.com/coder/coder-platformx-notifications README to include them as an example in the Coder docs

preview

@EdwardAngert EdwardAngert requested a review from bpmct February 3, 2025 15:35
@EdwardAngert EdwardAngert self-assigned this Feb 3, 2025
@EdwardAngert EdwardAngert changed the title edit PlatformX doc with steps from README docs: edit PlatformX doc with steps from README Feb 3, 2025
@EdwardAngert EdwardAngert changed the title docs: edit PlatformX doc with steps from README docs: update PlatformX doc with steps from README Feb 3, 2025
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, I'm still in favor of keeping the source of truth in the README since many people will want to read/fork/modify the code before deploying and deploying is arbitrary (e.g. I didn't package it via helm, etc).

If we do want to keep the docs here (I previewed it and it looks good), let's definitely link to the repo still and reconsider what we want to put in the README (maybe we link the README to the docs, then)?

@EdwardAngert EdwardAngert requested a review from bpmct February 3, 2025 19:00
Comment on lines 15 to 21
- A running Coder v2.19+ deployment
- A PlatformX subscription from [DX](https://getdx.com/)
- A platform to host the integration (choose any of these):
- AWS Lambda
- Heroku
- Kubernetes
- Or any other platform that can run Python web applications
Copy link
Member

@bpmct bpmct Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where should we put the requirements? Why was this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was my mistake - I think I cut it while moving it and then didn't put it back

un-removed it

- AWS Lambda
- Google Cloud Run
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this based on the readme

This middleware is optimized for serverless environments such as Google Cloud Run and AWS Lambda.

@bpmct
Copy link
Member

bpmct commented Feb 3, 2025

Let's ship it :) can always adjust based on feedback

@EdwardAngert EdwardAngert merged commit 7bda04d into dx-integration Feb 3, 2025
27 checks passed
@EdwardAngert EdwardAngert deleted the ea-dx-integration branch February 3, 2025 22:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2025
@stirby
Copy link
Collaborator

stirby commented Feb 4, 2025

/cherry-pick release/2.19

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants