Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: match StatusIndicator component with the new designs #16458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma self-assigned this Feb 5, 2025
@BrunoQuaresma BrunoQuaresma changed the title refactor: update StatusIndicator component to match the new designs refactor: match StatusIndicator component with the new designs Feb 5, 2025
@jaaydenh
Copy link
Contributor

jaaydenh commented Feb 5, 2025

@BrunoQuaresma when I test this I am not seeing the status indicators for the drop downs for workspace status or user status. Also, the status indicators are removed in most of the chromatic diffs. Also, is it intention that the never state for a workspace has not status indicator?

Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrunoQuaresma BrunoQuaresma merged commit 8a3a79f into main Feb 7, 2025
30 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-status-indicator branch February 7, 2025 18:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants