chore: update table component and styles #16541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaaydenh
commented
Feb 12, 2025
- migrate styles to tailwind
- migrate to new Table component
brettkolodny
approved these changes
Feb 12, 2025
| /> | ||
| <UserGroupsCell userGroups={member.groups} /> | ||
| <TableCell> | ||
| {member.user_id !== me.id && canEditMembers && ( |
There was a problem hiding this comment.
nit: I personally try to avoid conditional rendering with && and instead will use a ternary. The reason being that I've been burned one too many times by the issue described in the Pitfall note in the React docs.
But I see && used a lot within the code base, and this case doesn't fall into the issue so just wanted to bring it up just in case!
There was a problem hiding this comment.
Ya you will notice this this pattern everywhere the component is used. I think right now ternaries only get used if there is something to return in both the true and false case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.