Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(coderd/httpapi): add QueryParamParser.JSONStringMap #16578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2025
Merged

feat(coderd/httpapi): add QueryParamParser.JSONStringMap #16578

merged 3 commits into from
Feb 18, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Feb 14, 2025 •
edited
Loading

This PR provides a convenience function for parsing a map[string]string from a query parameter.

Context: #16558 (comment)

@johnstcn johnstcn self-assigned this Feb 14, 2025
@johnstcn johnstcn requested review from mafredri and Emyrk February 14, 2025 15:33
@johnstcn johnstcn mentioned this pull request Feb 14, 2025
Merged
mafredri
mafredri reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Could we also update existing code to use this implementation? Should serve to also verify its behavior.

@johnstcn johnstcn force-pushed the cj/queryparser-stringmap branch from 1ade009 to 4fec855 Compare February 18, 2025 12:56
@johnstcn
Copy link
Member Author

Nice addition! Could we also update existing code to use this implementation? Should serve to also verify its behavior.

Updated!

@johnstcn johnstcn merged commit 3a77375 into main Feb 18, 2025
30 checks passed
@johnstcn johnstcn deleted the cj/queryparser-stringmap branch February 18, 2025 14:14
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@Emyrk Emyrk Emyrk approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnstcn @mafredri @Emyrk