feat: enable soft delete for organizations#16584
Merged
Conversation
87af79e to
44a9cad
Compare
Emyrk
reviewed
Feb 18, 2025
coderd/database/migrations/000295_organization_soft_delete.up.sql
Outdated
Show resolved
Hide resolved
6d8239c to
083bf7f
Compare
f23940d to
70bf5e3
Compare
jaaydenh
commented
Feb 21, 2025
| -- * the organization has 1 or more groups other than "Everyone" group | ||
| -- * the organization has 1 or more members other than the organization owner | ||
|
|
||
| IF (workspace_count + template_count) > 0 THEN |
Contributor
Author
There was a problem hiding this comment.
it feels like such a long error message if this is combined into one exception. In the future the FE should let the user know what resources exist before deleting
Member
There was a problem hiding this comment.
We can improve the error handling in golang up front in the future and improve the UX on failures.
Emyrk
reviewed
Feb 21, 2025
coderd/database/migrations/000296_organization_soft_delete.up.sql
Outdated
Show resolved
Hide resolved
Emyrk
reviewed
Feb 21, 2025
Emyrk
reviewed
Feb 21, 2025
Emyrk
approved these changes
Feb 24, 2025
Co-authored-by: Steven Masley <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.