chore: reduce log volume on server startup #16608
Conversation
bfaffb7 to
e18ef6f
Compare
5c7de02 to
b1b217b
Compare
There was a problem hiding this comment.
Some nice changes in here, thanks. Had a few comments/concerns and CC'd @johnstcn and @spikecurtis on the ones I was uncertain about.
Hmm, looks like something went awry with the review. ccs for Cian on crypto, Spike on tailnet seem to be gone 😅 .
54b3e03 to
2f31144
Compare
2f31144 to
c9033d8
Compare
provisioner/terraform/serve.go
Outdated
| slog.F("max_version", maxTerraformVersion.String())) | ||
| // When running in-memory provisioners, each one reaches this point. | ||
| // It's not useful to print this to the user multiple times, so we ensure to log it once. | ||
| if !loggedVersion.Swap(true) { |
There was a problem hiding this comment.
It's possible now that we end up logging on a minor terraform version mis-match, in which case we end up downloading a newer one and this log ends up reporting incorrect information.
Perhaps it's better moved to Serve?
PS. If we can avoid the package level state, that'd be great (for instance, can be a source of flaky tests).
There was a problem hiding this comment.
I didn't address this one yet - let me fix that before merging.
c9033d8 to
eaac36e
Compare
eaac36e to
e019f3c
Compare
e019f3c to
1e6d7ec
Compare
Addresses #16231.
This PR reduces the volume of logs we print after server startup in order to surface the web UI URL better.
Here are the logs after the changes a couple of seconds after starting the server:
The warning is due to running a development site-less build. It wouldn't show in a release build.