Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: return http 204 on test notification #16651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2025
Merged

fix: return http 204 on test notification #16651

merged 2 commits into from
Feb 21, 2025

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Feb 21, 2025 •
edited
Loading

This PR changes the API response for /api/v2/notifications/test endpoint to HTTP 204 / No Content.

@mtojek mtojek self-assigned this Feb 21, 2025
@mtojek mtojek marked this pull request as ready for review February 21, 2025 12:13
DanielleMaywood
DanielleMaywood approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@DanielleMaywood DanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtojek mtojek merged commit fcc9b05 into main Feb 21, 2025
30 checks passed
@mtojek mtojek deleted the fix-test-notif-api branch February 21, 2025 12:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DanielleMaywood DanielleMaywood DanielleMaywood approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @DanielleMaywood