Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(cli): fix test flake in TestSSH_Container/NotFound #16771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Mar 3, 2025

If you hit the list containers endpoint with no containers running, the response is different. This uses a mock lister to ensure a consistent response from the agent endpoint.

@johnstcn johnstcn requested a review from defelmnq March 3, 2025 13:09
@johnstcn johnstcn self-assigned this Mar 3, 2025
Copy link
Contributor

@defelmnq defelmnq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! 🎉

@johnstcn johnstcn merged commit ca23abc into main Mar 3, 2025
32 checks passed
@johnstcn johnstcn deleted the cj/flake-test-ssh-container-not-found branch March 3, 2025 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants