Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
b8cfe76
feat: add support for one-way websockets to UI
Parkreiner Mar 7, 2025
367906d
fix: apply formatting
Parkreiner Mar 7, 2025
09f5e95
docs: remove outdated comment
Parkreiner Mar 7, 2025
04a3846
fix: add missing clear call
Parkreiner Mar 7, 2025
ca8e94f
fix: streamline biome fixes
Parkreiner Mar 7, 2025
81a723a
fix: resolve Storybook metadata setup bug
Parkreiner Mar 12, 2025
4364a3d
docs: make warning more obvious
Parkreiner Mar 12, 2025
ecb2940
fix: beef up socket retry logic
Parkreiner Mar 12, 2025
bfe4d9f
fix: make it harder to initialize OWWS
Parkreiner Mar 12, 2025
6cdfc21
fix: apply feedback
Parkreiner Mar 12, 2025
682e2f4
fix: update JSDoc
Parkreiner Mar 12, 2025
20ad778
Merge branch 'main' into mes/one-way-ws-02
Parkreiner Mar 18, 2025
9b19ceb
chore: add missing socket unit tests
Parkreiner Mar 18, 2025
423910f
fix: update notifications code to use OWWS
Parkreiner Mar 18, 2025
247dbb6
Merge branch 'mes/one-way-ws-01' into mes/one-way-ws-02
Parkreiner Mar 18, 2025
6e3e0d8
fix: remove comment about what to test
Parkreiner Mar 18, 2025
c422379
fix: make class fields readonly
Parkreiner Mar 19, 2025
0824dd4
fix: sort imports
Parkreiner Mar 19, 2025
db448d7
Merge branch 'mes/one-way-ws-01' into mes/one-way-ws-02
Parkreiner Mar 19, 2025
60bf505
Merge branch 'mes/one-way-ws-01' into mes/one-way-ws-02
Parkreiner Mar 25, 2025
c1cee57
refactor: make tests more maintainable
Parkreiner Mar 25, 2025
70b74e2
fix: remove unused type alias
Parkreiner Mar 25, 2025
8e34e91
fix: make mock publisher more robust
Parkreiner Mar 25, 2025
8db068a
Merge branch 'mes/one-way-ws-01' into mes/one-way-ws-02
Parkreiner Mar 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: streamline biome fixes
  • Loading branch information
Parkreiner committed Mar 7, 2025
commit ca8e94f0bfa360f32d66684dda5f901c71b8716d
15 changes: 6 additions & 9 deletions site/src/api/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1081,27 +1081,25 @@ class ApiMethods {
};

getWorkspaceByOwnerAndName = async (
username: string | undefined,
username: string,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Biome was complaining about having default parameters not be at the end of the function signature, but also, we were never calling these functions with an explicit value of undefined

workspaceName: string,
params?: TypesGen.WorkspaceOptions,
): Promise<TypesGen.Workspace> => {
const user = username || "me";
const response = await this.axios.get<TypesGen.Workspace>(
`/api/v2/users/${user}/workspace/${workspaceName}`,
`/api/v2/users/${username}/workspace/${workspaceName}`,
{ params },
);

return response.data;
};

getWorkspaceBuildByNumber = async (
username: string | undefined,
username: string,
workspaceName: string,
buildNumber: number,
): Promise<TypesGen.WorkspaceBuild> => {
const name = username || "me";
const response = await this.axios.get<TypesGen.WorkspaceBuild>(
`/api/v2/users/${name}/workspace/${workspaceName}/builds/${buildNumber}`,
`/api/v2/users/${username}/workspace/${workspaceName}/builds/${buildNumber}`,
);

return response.data;
Expand Down Expand Up @@ -1282,12 +1280,11 @@ class ApiMethods {
};

createWorkspace = async (
userId: string | undefined,
userId: string,
workspace: TypesGen.CreateWorkspaceRequest,
): Promise<TypesGen.Workspace> => {
const id = userId || "me";
const response = await this.axios.post<TypesGen.Workspace>(
`/api/v2/users/${id}/workspaces`,
`/api/v2/users/${userId}/workspaces`,
workspace,
);

Expand Down
Loading