Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: name null users in audit logs #16890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

A few audit logs can have the user as null which means the user is not authenticated when executing the action. To make it more explicit we named than as "Unauthenticated user" in the log description instead of "undefined user".

@BrunoQuaresma BrunoQuaresma added the hotfix PRs only. Harmless small change. Only humans may set this. label Mar 12, 2025
@BrunoQuaresma BrunoQuaresma requested a review from mafredri March 12, 2025 13:59
@BrunoQuaresma BrunoQuaresma self-assigned this Mar 12, 2025
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@BrunoQuaresma BrunoQuaresma merged commit 78df786 into main Mar 12, 2025
34 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/undefined-user branch March 12, 2025 14:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2025
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants