Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: enable SBOM attestations for docker images #16894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 13, 2025
Merged

chore: enable SBOM attestations for docker images #16894

merged 5 commits into from
Mar 13, 2025

Conversation

matifali
Copy link
Member

@matifali matifali commented Mar 12, 2025

  • Enable SBOM and provenance attestations in Docker builds
  • Installs cosign and syft in dogfood image
  • Adds github attestations

Signed-off-by: Thomas Kosiewski [email protected]

matifali and others added 2 commits March 12, 2025 14:16
- Enable SBOM and provenance attestations in Docker builds
- Update build_docker_multiarch.sh to handle images with attestations
- Fix issue with Docker manifest creation for images with multiple attestation manifests
- Make Docker daemon config use containerd by default

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>

Signed-off-by: Thomas Kosiewski <[email protected]>
Change-Id: I3f9b6e0447713eb16e50af9b1645d6cacf1af9fa
Signed-off-by: Thomas Kosiewski <[email protected]>
matifali and others added 2 commits March 12, 2025 22:12
…images

This adds GitHub Actions attestations to both CI and release workflows,
providing SLSA provenance verification for all Docker images built in the
pipeline. This complements our existing cosign SBOM attestations to improve
our software supply chain security posture.

- Add attestations:write permission to both workflows
- Add SLSA provenance attestation for all Docker image tags
- Include error handling to make attestation failures non-blocking
- Add detailed comments explaining the attestation strategy

Change-Id: I06761204cdcd31a0a648acfd057bcd45f55bdc9c
Signed-off-by: Thomas Kosiewski <[email protected]>
The installation of Syft and Cosign in the dogfood Dockerfile was missing an &&
operator between commands, causing the build to fail. This commit adds the missing
operator to ensure proper command chaining.

Change-Id: I540258ed9638581d7ee704915a2f261d0aed7beb
Signed-off-by: Thomas Kosiewski <[email protected]>
Copy link
Member Author

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great except the go version bump.

@@ -9,7 +9,7 @@ RUN cargo install exa bat ripgrep typos-cli watchexec-cli && \
FROM ubuntu:jammy@sha256:0e5e4a57c2499249aafc3b40fcd541e9a456aab7296681a3994d631587203f97 AS go

# Install Go manually, so that we can control the version
ARG GO_VERSION=1.22.8
ARG GO_VERSION=1.24.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

@matifali matifali merged commit 4987de6 into main Mar 13, 2025
37 checks passed
@matifali matifali deleted the atif/sbom branch March 13, 2025 16:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2025
@matifali
Copy link
Member Author

As a follow up lets add a docs section on how to verify the sbom.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants