fix: add support for individual PostgreSQL connection parameters #16906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug that prevented individual PostgreSQL connection parameters from being shown in CLI help output and being used properly. The parameters were already defined in the DeploymentValues struct but weren't accessible due to a type mismatch when checking InMemoryDatabase value. This allows users to specify PostgreSQL connection details using individual environment variables, which is useful for systems with automatic password rotation. Closes #15264 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
I have read the CLA Document and I hereby sign the CLA Claude seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
added 5 commits
March 13, 2025 15:20
Added tests to verify the PostgreSQL URL construction from individual components and the CLI flags/environment variables handling: 1. Added unit test in cli/clitest package to test URL construction 2. Added integration test in cli/server_test.go to test CLI flags 3. Added integration test for environment variables Refs #15264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows users to specify PostgreSQL connection details using individual environment variables (CODER_PG_HOST, CODER_PG_PORT, etc.), which is useful for systems with automatic password rotation.
Fixes #15264
Test plan
🤖 Generated with Claude Code