feat(coderd): remove greetings from notifications templates #16991
Conversation
|
For context and after discussing with @DanielleMaywood - we could have also done it using some SQL functions - but I preferred instead to rewrite all notifications to have a kind of 'checkpoint' on which we know what all notifications should look like. We had a few migrations to UPDATE the body and it became complicated to track - this migration both removes the greetings and creates this 'checkpoint'. |
DanielleMaywood
left a comment
There was a problem hiding this comment.
I think maybe a couple notifications have been missed
coderd/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceDormant.html.golden
Outdated
Show resolved
Hide resolved
...otifications/testdata/rendered-templates/smtp/TemplateWorkspaceMarkedForDeletion.html.golden
Outdated
Show resolved
Hide resolved
|
Thanks @DanielleMaywood for the first review - I fixed the missing templates.
|
DanielleMaywood
left a comment
There was a problem hiding this comment.
Other than this change, looks good to me 👍
|
Apologies for not noticing sooner but another quick read through I've the plaintext golden files are missing the greeting. |
mtojek
left a comment
There was a problem hiding this comment.
only one comment on indentation, otherwise LGTM
| {{ .Labels._subject }} | ||
| </h1> | ||
| <div style="line-height: 1.5;"> | ||
| <p>Hi {{ .UserName }},</p> |
There was a problem hiding this comment.
Let's fix the indentation (2 spaces?)
There was a problem hiding this comment.
Should be better ✅ I also regenerated.
It still creates a few changes on the golden-files which is cool I think as they were not uniformized - not they will be.
This PR aimes to fix this issue -
The main idea is to remove greetings from templates stored in the DB - and instead push it into the template for require methods - for now SMTP.