Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: allow specifying devcontainer on agent in terraform #16997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Mar 20, 2025
Merged

feat: allow specifying devcontainer on agent in terraform #16997

merged 23 commits into from
Mar 20, 2025

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Mar 19, 2025 •
edited
Loading

This change allows specifying devcontainers in terraform and plumbs it through to the agent via agent manifest.

This will be used for autostarting devcontainers in a workspace.

Depends on coder/terraform-provider-coder#368
Updates #16423

@mafredri mafredri force-pushed the mafredri/feat-add-agent-devcontainers branch from 8e2d86e to 2d72c03 Compare March 19, 2025 13:57
@mafredri mafredri mentioned this pull request Mar 19, 2025
Merged
@mafredri mafredri force-pushed the mafredri/feat-add-agent-devcontainers branch from 05e50d7 to 885869f Compare March 19, 2025 14:24
@mafredri mafredri marked this pull request as ready for review March 19, 2025 16:07
@mafredri mafredri force-pushed the mafredri/feat-add-agent-devcontainers branch 2 times, most recently from 26bd7df to 2c9ccf2 Compare March 19, 2025 16:22
johnstcn
johnstcn reviewed Mar 19, 2025
View reviewed changes
johnstcn
johnstcn approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

EDIT: I think you need to fix something in the typegen though:

https://github.com/coder/coder/actions/runs/13968677521/job/39104925348?pr=16997#step:11:992

spikecurtis
spikecurtis previously requested changes Mar 20, 2025
View reviewed changes
@mafredri mafredri force-pushed the mafredri/feat-add-agent-devcontainers branch from b5c5b4c to 1544b49 Compare March 20, 2025 16:02
@mafredri mafredri force-pushed the mafredri/feat-add-agent-devcontainers branch from 1544b49 to 82df8d6 Compare March 20, 2025 16:08
@mafredri mafredri requested a review from spikecurtis March 20, 2025 16:10
@mafredri mafredri merged commit 69ba27e into main Mar 20, 2025
33 of 35 checks passed
@mafredri mafredri deleted the mafredri/feat-add-agent-devcontainers branch March 20, 2025 17:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@DanielleMaywood DanielleMaywood Awaiting requested review from DanielleMaywood

@SasSwart SasSwart Awaiting requested review from SasSwart

@spikecurtis spikecurtis Awaiting requested review from spikecurtis spikecurtis is a code owner

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mafredri @johnstcn @spikecurtis @DanielleMaywood