chore: improve error logging in TestServer/EphemeralDeployment #17184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Apr 1, 2025
Comment on lines
+211
to
+213
| case <-matchCh1: | ||
| // OK! | ||
| } |
There was a problem hiding this comment.
If you have the matched string here, why not move the assertions from L214-220 in here?
There was a problem hiding this comment.
I wanted to keep modifications to the existing test to a minimum.
cli/server_test.go
Outdated
Comment on lines
222
to
231
| matchCh2 := make(chan string, 1) | ||
| go func() { | ||
| matchCh2 <- pty.ExpectMatchContext(ctx, "View the Web UI") | ||
| }() | ||
| select { | ||
| case err := <-errCh: | ||
| require.NoError(t, err) | ||
| case <-matchCh2: | ||
| // OK! | ||
| } |
There was a problem hiding this comment.
Why do we actually care about this message being logged?
There was a problem hiding this comment.
It's a decent indicator that the server was successfully set up. Let me add a comment about it.
johnstcn
approved these changes
Apr 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a flake reported in coder/internal#549 that was caused by the built-in Postgres failing to start. However, the test was written in a way that didn't log the actual error which caused Postgres to fail. This PR improves error logging in the affected test so that the next time the error happens, we know what it is.