feat: Add resource type and restyle terminal link #1722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoQuaresma
commented
May 24, 2022
| className={className} | ||
| target="_blank" | ||
| > | ||
| <ComputerIcon /> |
There was a problem hiding this comment.
The version of Material UI we are using does not have the Terminal icon 😢
presleyp
reviewed
May 24, 2022
| import React from "react" | ||
| import * as TypesGen from "../../api/typesGenerated" | ||
|
|
||
| export const Language = { | ||
| linkText: "Open in terminal", | ||
| linkText: "Open terminal", |
There was a problem hiding this comment.
@kylecarbs which makes more sense?
There was a problem hiding this comment.
I removed this to save some space 😆
There was a problem hiding this comment.
I'm impartial! I think it's fair to remove the in to save space, but up to you!
|
Thanks for doing this! It looks great in context, but the story for just the terminal link has an alignment problem, maybe it needs a container or something. |
Kira-Pilot
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1721