-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: remove site wide perms from creating a workspace #17296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
38124bd
fix: creating workspaces should not require site wide permissions
Emyrk bf891a4
feat: remove site wide perms from creating a workspace
Emyrk 110809e
remove dead code
Emyrk dbdf49f
chore: fixup permission assertions and testing
Emyrk d40ec9c
forgot to commit a file
Emyrk a339587
linting
Emyrk 6ac8a92
rename authz err
Emyrk 0f26830
move noop response writer
Emyrk 1f46264
rename err
Emyrk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
forgot to commit a file
- Loading branch information
commit d40ec9cdf755ba443d7bf8dec19618b872aa332f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package httpmw | ||
|
|
||
| import "net/http" | ||
|
|
||
| // noopResponseWriter is a response writer that does nothing. | ||
| type noopResponseWriter struct{} | ||
|
|
||
| func (noopResponseWriter) Header() http.Header { return http.Header{} } | ||
| func (noopResponseWriter) Write(p []byte) (int, error) { return len(p), nil } | ||
| func (noopResponseWriter) WriteHeader(int) {} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.