-
Notifications
You must be signed in to change notification settings - Fork 881
feat: UI for canceling workspace builds #1735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think so, because if I try to start, and it fails, the workspace is in an unknown state and stopping or deleting may be helpful.
Good idea! @kylecarbs mind if I leave this for you to do in the deleting ticket? |
@presleyp since we don't have larger labels anymore like "Connecting workspace" I think we could reduce the WorkspaceAction width a bit. What do you think? |
@BrunoQuaresma ready for final review |
@presleyp I canceled a workspace a couple times and now I see I have the option to both start and stop it. Is this expected? |
@Kira-Pilot yes, canceling an action leaves the workspace in an unknown state, so if it was started and you clicked stop and then cancel, it's not still started, it's in limbo. So from there you can get it back in a known state by starting or stopping. We'll definitely need to display some info about this, I think there's a ticket for figuring out how to explain stuff to the user. |
@presleyp got it; i think you explained that to Bruno above but I didn't see it. yeah, instead of explaining it to them, I wonder if we actually hide one of the 'choices' and just make a choice for them. Choice in this scenario feels confusing to me. Something to tackle later! |
* Start hooking up cancel * Update xservice * Render cancel Changes behavior of other buttons too * Make outdated workspace story show max buttons * Remove retry code * Remove loading button state * Fix type, extend tests * Update story
Closes #233
I'm putting this up as a draft for design review. If y'all like it, I'll finish removing the Retry code.