chore: typescript to accept null golang maps
#17435
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golang can encode maps as `null`. The `Record` type is therefore not sufficient to fully describe the data.
1c5984d to
5068814
Compare
|
I'm wondering if they should be null or undefined 🤔 if they are not present in the response at all, I would use undefined. Do you need help to fix the FE type errors? |
@BrunoQuaresma It is https://go.dev/play/p/N2BJVhMCKXu {"Map":null}Yes, I was looking for an FE engineer to take this PR and fixup the FE changes. The |
|
Awesome, I will take a look into this during this week 👍 Awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang can encode maps as
null. TheRecordtype is therefore not sufficient to fully describe the data.https://go.dev/play/p/N2BJVhMCKXu
We can get errors like this: #17430
