Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add link to provisioner jobs and daemons #17509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 28, 2025
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

Close #17314

Demo

Screen.Recording.2025-04-22.at.11.18.42.mov

Changes

  • Added the xs button variant
  • Display all the daemons - idle and offline - and set a size limit to 100 results (explanation in the demo)
  • Filter daemons and jobs by ID

@BrunoQuaresma BrunoQuaresma requested a review from a team April 22, 2025 15:25
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 22, 2025
@BrunoQuaresma BrunoQuaresma requested review from aqandrew and removed request for a team April 22, 2025 15:25
Copy link
Contributor

@brettkolodny brettkolodny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits but I think there are some opportunities to clean up some unsafe code

Copy link
Contributor

@brettkolodny brettkolodny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@BrunoQuaresma BrunoQuaresma merged commit 3ab3ef8 into main Apr 28, 2025
40 of 41 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/link-provisioners branch April 28, 2025 14:38
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link provisioners and provisioner jobs in the UI
2 participants