-
Notifications
You must be signed in to change notification settings - Fork 881
refactor(site): centralize time values in render functions as deterministic state #17587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Parkreiner
wants to merge
32
commits into
main
Choose a base branch
from
mes/use-time-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Parkreiner does this have any relation to the Time Variance Authority (TVA) in the Marvel Universe? |
No, but that is where Class Variance Authority got its name from (which we use in the frontend to manage style variants) |
Parkreiner
commented
Apr 30, 2025
…mes/use-time-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Mainly getting this in place to get feedback on the interfaces now, but I might not be able to start this officially until the next sprint.
Examples of using the hook
Getting a new date from the hook (the hook will trigger an update to TimeSync every second, unless there is another consumer that's mounted and has a faster update interval)
Getting a one-time date from the hook (the hook can still re-render if there are other consumers that trigger an update)
Getting a derived value from the hook (even if there is an update for the underlying TimeSync class, the hook will only re-render if the result of the
select
call is different compared to last time)With explicit type parameter