refactor: use specific error for agpl and prebuilds #17591
Merged
+36
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannykopping
approved these changes
Apr 28, 2025
coderd/workspaces.go
Outdated
| !errors.Is(err, prebuilds.ErrAGPLDoesNotSupportPrebuilds) { | ||
| !errors.Is(err, prebuilds.ErrAGPLDoesNotSupportPrebuiltWorkspaces) { | ||
| api.Logger.Error(ctx, "failed to claim prebuilt workspace", slog.Error(err), | ||
| slog.F("workspace_name", req.Name), slog.F("template_version_preset_id", req.TemplateVersionPresetID)) |
There was a problem hiding this comment.
I should've been more clear, sorry. I meant we should log when the error is of one of the expected types.
There was a problem hiding this comment.
- maybe let's log in both cases? Because if unexpected error is happened it also make sense to log? Or it will be logged on another level because handler failed?
- do you want to log it with error or warning? Because
ErrNoClaimablePrebuiltWorkspacesis not an actual error? It can be normal situation.
There was a problem hiding this comment.
Sounds reasonable. Warning for expected cases, error for unexpected 👍
There was a problem hiding this comment.
@dannykopping it became too wordy, but I guess it's okay?
…ebuild-follow-up-2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR to #17458
Addresses this discussion: #17458 (comment)