chore: fix agent tests on Windows 11 #17631
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33090d2 to
825b326
Compare
mafredri
reviewed
May 7, 2025
| { | ||
| key: "HOME", | ||
| want: u.HomeDir, | ||
| }, |
There was a problem hiding this comment.
Could we set HOME here instead?
coder/agent/agentssh/agentssh.go
Line 912 in df0c6ed
This is what OpenSSH does as well: https://github.com/openssh/openssh-portable/blob/7cc8e150d51a4545b86d996692b541419b35d1a3/session.c#L991
Almost added it last time I was excavating here but I opted on the side of caution. 😅
| @@ -1502,7 +1498,7 @@ func TestAgent_Lifecycle(t *testing.T) { | |||
|
|
|||
| _, client, _, _, _ := setupAgent(t, agentsdk.Manifest{ | |||
| Scripts: []codersdk.WorkspaceAgentScript{{ | |||
| Script: "true", | |||
| Script: "echo foo", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple agent tests so that they work correctly on Windows.
HOMEis not a standard Windows environment variable, and we don't have any specific Code in Coder to set it on SSH, so I've removed the test case. Amazingly/bizarrely the Windows test runners set this variable, but this is not standard Windows behavior so we shouldn't be including it in our tests.Also the command
trueis not valid on a default Windows install.I'm not really sure how the CI runners are allowing this test to pass, but again, it's not standard so we shouldn't be doing it.