fix(codersdk/toolsdk): ensure all tools include required fields of aisdk.Schema #17632
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation tests for the AISDK Schema in all tools and ensures that each tool’s schema includes the required "Properties" and "Required" fields.
- Added a new test (TestToolSchemaFields) in toolsdk_test.go to validate that all tools have non-nil Schema.Properties and Schema.Required, and that each required field has a corresponding property.
- Updated toolsdk.go for the ListWorkspaces and DeleteTemplate tools to include or enforce the Required fields as part of the tool schema.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| codersdk/toolsdk/toolsdk_test.go | Added tests to verify that each tool contains the required Schema fields. |
| codersdk/toolsdk/toolsdk.go | Updated tool definitions to include the "Required" field in the schema. |
ThomasK33
approved these changes
May 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.