fix: extract checkbox label from dynamic parameter styling prop #17651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
reviewed
May 1, 2025
|
@aslilac improved the handling of parameter styling |
aslilac
reviewed
May 5, 2025
| @@ -470,6 +471,7 @@ export const CreateWorkspacePageViewExperimental: FC< | |||
|
|
|||
| <div className="flex flex-col gap-9"> | |||
| {parameters.map((parameter, index) => { | |||
| const styling = parameter.styling as ParameterStyling; | |||
There was a problem hiding this comment.
yeah but this is still an inline cast. whatever the type of parameter is here should have a styling: ParameterStyling; member.
There was a problem hiding this comment.
Updated the styling type in coder/preview
0fca373 to
81e4f77
Compare
aslilac
approved these changes
May 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #17474
A label will only be shown next to the checkbox If there is a value for
labelin the styling prop for the dynamic parameter