fix: persist terraform modules during template import #17665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikecurtis
reviewed
May 6, 2025
Emyrk
reviewed
May 6, 2025
Emyrk
reviewed
May 6, 2025
Emyrk
reviewed
May 6, 2025
There was a problem hiding this comment.
@spikecurtis is adding a new field to the proto struct backwards compatible like in json? Meaning, does the new field default to nil?
I will ✔️ once I know it's backwards compatible 👍
Emyrk
reviewed
May 6, 2025
Yes, it's back compatible at the proto layer, so only a minor version bump, assuming the server side will tolerate it being unset. Can't recall whether |
6b08bb0 to
51cebae
Compare
Emyrk
reviewed
May 7, 2025
provisioner/terraform/testdata/modules-source-caching/.terraform/modules/example_module/main.tf
Show resolved
Hide resolved
Emyrk
approved these changes
May 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to save the source code of the terraform modules at import, so that they're available for evaluation with dynamic parameters.
The provisioner downloads the modules during the plan, which means we can have it create a tar file, send it to the backend, and then we can persist it in the database for later use.