chore: reduce "Upload tests to datadog" times in CI #17668
Conversation
bb80dee to
5d42295
Compare
| exit 1 | ||
| fi | ||
|
|
||
| echo "Downloading DataDog CI binary version ${BINARY_VERSION} for ${{ runner.os }}..." |
There was a problem hiding this comment.
Which will be hard now that the version is an input...
There was a problem hiding this comment.
I'll remove the input then
There was a problem hiding this comment.
Why would it need SHA256 validation? We are downloading from the official repo, and also, the CLI only works if the correct token is available? Also, the test logs are all public; there is no sensitive data. Or. is it, and I am missing something?
There was a problem hiding this comment.
It mitigates supply-chain attacks. If somebody took over Datadog's repo, they'd be able to swap the release files for a malicious payload. AFAIK, release artifacts are mutable.
There was a problem hiding this comment.
@deansheather I added hash verification
5d42295 to
f589664
Compare
| BINARY_HASH_MACOS="e87c808638fddb21a87a5c4584b68ba802965eb0a593d43959c81f67246bd9eb" | ||
| BINARY_HASH_LINUX="5e700c465728fff8313e77c2d5ba1ce19a736168735137e1ddc7c6346ed48208" | ||
|
|
||
| TMP_DIR=$(mktemp -d) |
There was a problem hiding this comment.
Could this go in runner temp instead so it hits the ramdisk? The perf savings are probably miniscule but might as well
There was a problem hiding this comment.
The perf savings are probably miniscule
Indeed, I don't think it's worth optimizing further if the entire step already takes only 3 seconds
|
For future reference, this helps unblock #15109. |
This PR speeds up the "Upload tests to datadog" step by downloading the
datadog-cibinary directly from GitHub releases. Most of the time used to be spent innpm install, which consistently timed out on Windows after a minute. Now it takes 3 seconds.I updated it to version v2.48.0 because v2.21.0 didn't have the artifacts for arm64 macOS.