Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: fix TestWorkspaceAgentReportStats flake #17678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

test: fix TestWorkspaceAgentReportStats flake #17678

merged 1 commit into from
May 5, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented May 5, 2025 •
edited
Loading

Closes coder/internal#609.

As seen in the below logs, the last_used_at time was updating, but just to the same value that it was on creation; dbtime.Now was called in quick succession.

 t.go:106: 2025-05-05 12:11:54.166 [info]  coderd.workspace_usage_tracker: updated workspaces last_used_at  count=1  now="2025-05-05T12:11:54.161329Z"
    t.go:106: 2025-05-05 12:11:54.172 [debu]  coderd: GET  host=localhost:50422  path=/api/v2/workspaces/745b7ff3-47f2-4e1a-9452-85ea48ba5c46  proto=HTTP/1.1  remote_addr=127.0.0.1  start="2025-05-05T12:11:54.1669073Z"  workspace_name=peaceful_faraday34  requestor_id=b2cf02ae-2181-480b-bb1f-95dc6acb6497  requestor_name=testuser  requestor_email=""  took=5.2105ms  status_code=200  latency_ms=5  params_workspace=745b7ff3-47f2-4e1a-9452-85ea48ba5c46  request_id=7fd5ea90-af7b-4104-91c5-9ca64bc2d5e6
    workspaceagentsrpc_test.go:70: 
        	Error Trace:	C:/actions-runner/coder/coder/coderd/workspaceagentsrpc_test.go:70
        	Error:      	Should be true
        	Test:       	TestWorkspaceAgentReportStats
        	Messages:   	2025-05-05 12:11:54.161329 +0000 UTC is not after 2025-05-05 12:11:54.161329 +0000 UTC

If we change the initial LastUsedAt time to be a time in the past, ticking with a dbtime.Now will always update it to a later value. If it never updates, the condition will still fail.

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson requested a review from hugodutka May 5, 2025 13:18
@ethanndickson ethanndickson marked this pull request as ready for review May 5, 2025 13:18
hugodutka
hugodutka approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@hugodutka hugodutka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Ethan!

@ethanndickson ethanndickson merged commit 4369765 into main May 5, 2025
49 checks passed
@ethanndickson ethanndickson deleted the ethan/fix-stats-last-used-at-flake branch May 5, 2025 14:15
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hugodutka hugodutka hugodutka approved these changes

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: TestWorkspaceAgentReportStats
2 participants
@ethanndickson @hugodutka