chore: update design of External auth section of CreateWorkspacePage #17683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoQuaresma
approved these changes
May 5, 2025
There was a problem hiding this comment.
I think it looks ok, but I have a few design considerations:
- The list items in the design don't have a space
- The "Authenticated" text should be xs to match the same text size in the button. I think it makes the things more balanced
- I think "Authenticate" for the button label should be enough since the item already has the provider name
PS: These are just considerations and not blockers, so I'm going to approve them 👍
|
@BrunoQuaresma Regarding using "Authenticate" for the button. I want to avoid using non-standard language unless it really seems better. "Login with Github" is much more common terminology and what most people should be used to. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to coder/preview#59
Figma: https://www.figma.com/design/SMg6H8VKXnPSkE6h9KPoAD/UX-Presets?node-id=2180-2995&t=RL6ICIf6KUL5YUpB-1
This updates the design of the External authentication section of the create workspace page form for both the existing and the new experimental create workspace pages.