refactor: update app buttons to use the new button component #17684
Conversation
| {children} | ||
| </Button> | ||
| ); | ||
| return <Button variant="outline" ref={ref} {...props} />; |
There was a problem hiding this comment.
What is purpose of keeping AgentButton around instead of removing it and using Button directly?
There was a problem hiding this comment.
This is a good question.
Since we want to have the TerminalLink, AppLink, VSCode buttons, etc. visually consistent, and be sure they are always looking the same, I just decided to keep the AgentButton. Of course, we could just set the variant in all these components, but since they are many (around 5 or 6 I guess) it would be easy to forget to update one of them when changing some of the styles (maybe it is not a problem since we have tests).
I'm going to refactor the apps logic very soon, so If I see it is just ok to remove the AgentButton, I will do.
|
I like the bigger icons. ❤️ |
Related to #17311
asChildcapability from the Radix componentsBefore:
After:
