fix: resolve flake test on manager #17702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
May 7, 2025
coderd/notifications/manager.go
Outdated
| @@ -141,6 +141,7 @@ func (m *Manager) Run(ctx context.Context) { | |||
| m.log.Info(ctx, "started") | |||
|
|
|||
| m.runOnce.Do(func() { | |||
| m.notifier = newNotifier(ctx, m.cfg, uuid.New(), m.log, m.store, m.handlers, m.helpers, m.metrics, m.clock) | |||
There was a problem hiding this comment.
Let's add a comment still why we're initializing this here so it doesn't move by accident 👍🏻
There was a problem hiding this comment.
I think the Run and Close of the manager is still racy, probably needs a mutex to avoid Run after Close, etc.
mtojek
approved these changes
May 8, 2025
coderd/notifications/manager_test.go
Outdated
| // SETUP | ||
|
|
||
| // nolint:gocritic // Unit test. | ||
| ctx := dbauthz.AsSystemRestricted(testutil.Context(t, testutil.WaitSuperLong)) |
There was a problem hiding this comment.
nit: testutil.WaitSuperLong - can we shorten the period?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes coder/internal#544