Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: fetch workspaces by username with organization permissions #17707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 8, 2025

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented May 7, 2025

Closes #17691

ExtractOrganizationMembersParam will allow fetching a user with only organization permissions. It gets a bit weird because if the user belongs to 0 orgs, then the user "does not exist" from an org perspective. But if you are a site-wide admin, then the user does exist.

@Emyrk Emyrk changed the title chore: fetching workspaces by username requires site user.read perms chore: fetching workspaces by username pass with organization permissions May 7, 2025
@Emyrk Emyrk changed the title chore: fetching workspaces by username pass with organization permissions chore: fetching workspaces by username to pass with organization permissions May 7, 2025
@Emyrk Emyrk changed the title chore: fetching workspaces by username to pass with organization permissions chore: fetch workspaces by username with organization permissions May 7, 2025
Emyrk added 4 commits May 7, 2025 15:40
Workspace apis scoped to an org should not require site wide perms.
Site wide perms should still work if the owner is not in an organzation
@Emyrk Emyrk force-pushed the stevenmasley/org_perms branch from d1d54ca to 18f4015 Compare May 7, 2025 20:40
@Emyrk Emyrk requested a review from aslilac May 8, 2025 16:51
@Emyrk Emyrk merged commit d5360a6 into main May 8, 2025
34 checks passed
@Emyrk Emyrk deleted the stevenmasley/org_perms branch May 8, 2025 19:41
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: failure when admins access workspaces on behalf of users
2 participants