Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: create ssh directory if it doesn't already exist when running coder config-ssh #17711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 8, 2025

Conversation

brettkolodny
Copy link
Contributor

Closes coder/internal#623

Warning

PR co-authored by Claude Code

@brettkolodny brettkolodny marked this pull request as ready for review May 8, 2025 13:33
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In terms of UX, I'm just wondering if we should ask the user first if it is ok to create the .ssh directory 🤔, but not a big deal tho.

@brettkolodny
Copy link
Contributor Author

Good point! I think it's fine because running the command already has this prompt though
CleanShot 2025-05-08 at 10 06 35

@brettkolodny brettkolodny merged commit c5c3a54 into main May 8, 2025
36 checks passed
@brettkolodny brettkolodny deleted the brett-i623/fix-create-ssh-dir-if-not-exist branch May 8, 2025 14:10
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: create .ssh folder if it does not exist already when running coder config-ssh
2 participants