Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: add safe list for external app protocols #17742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2025
Merged

refactor: add safe list for external app protocols #17742

merged 3 commits into from
May 9, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

To prevent malicious apps and vendors to use the Coder session token we are adding safe protocols/schemas we want to support.

  • vscode:
  • vscode-insiders:
  • windsurf:
  • cursor:
  • jetbrains-gateway:
  • jetbrains:

Fix https://github.com/coder/security/issues/77

@BrunoQuaresma BrunoQuaresma requested a review from spikecurtis May 9, 2025 14:29
@BrunoQuaresma BrunoQuaresma self-assigned this May 9, 2025
@BrunoQuaresma BrunoQuaresma added the hotfix PRs only. Harmless small change. Only humans may set this. label May 9, 2025
cdr-bot[bot]
cdr-bot bot approved these changes May 9, 2025
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@BrunoQuaresma BrunoQuaresma changed the title refactor: add external app protocols safe list refactor: add safe list for external app protocols May 9, 2025
@BrunoQuaresma BrunoQuaresma merged commit 9e44f18 into main May 9, 2025
34 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-protocols branch May 9, 2025 17:40
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BrunoQuaresma