Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: display user apps in the workspaces table #17744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented May 9, 2025

Related to #17311

Demo:
Screenshot 2025-05-09 at 11 46 59

@BrunoQuaresma BrunoQuaresma requested a review from a team May 9, 2025 14:48
@BrunoQuaresma BrunoQuaresma self-assigned this May 9, 2025
@BrunoQuaresma BrunoQuaresma requested review from brettkolodny and removed request for a team May 9, 2025 14:48
@@ -622,6 +624,9 @@ const PrimaryAction: FC<PrimaryActionProps> = ({
);
};

// The total number of apps that can be displayed in the workspace row
const WORKSPACE_APPS_SLOTS = 4;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps create a storybook to express this use case?

@BrunoQuaresma BrunoQuaresma added the hotfix PRs only. Harmless small change. Only humans may set this. label May 9, 2025
cdr-bot[bot]
cdr-bot bot previously approved these changes May 9, 2025
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is no longer a hotfix.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ❌ Less than 100 lines

@cdr-bot cdr-bot bot dismissed their stale review May 9, 2025 18:07

This PR is no longer a hotfix.

@BrunoQuaresma BrunoQuaresma requested a review from mtojek May 9, 2025 18:08
@BrunoQuaresma BrunoQuaresma merged commit 1adad41 into main May 9, 2025
34 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/display-user-apps branch May 9, 2025 20:01
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants