fix: list templates returns non-deprecated templates by default #17747
+19,510
−17,680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
cdrci2
added a commit
to coder/cla
that referenced
this pull request
May 9, 2025
cstyan
reviewed
May 9, 2025
| @@ -13021,7 +13021,7 @@ func (q *FakeQuerier) GetAuthorizedTemplates(ctx context.Context, arg database.G | |||
| if arg.ExactName != "" && !strings.EqualFold(template.Name, arg.ExactName) { | |||
| continue | |||
| } | |||
| if arg.Deprecated.Valid && arg.Deprecated.Bool == (template.Deprecated != "") { | |||
| if arg.Deprecated.Valid && arg.Deprecated.Bool != (template.Deprecated != "") { | |||
There was a problem hiding this comment.
I think a comment here might be useful as well. Initially I wanted to suggest renaming arg.Deprecated but I imagine that's a bigger change to roll out here. It's just not very nice to read this as something like
if arg.Deprecated.Valid && arg.IgnoreDeprecated && template.IsDeprecated
potentially the template struct could be refactored to have IsDeprecated and DeprecatedMessage as opposed to just having Deprecated message whose value being "some string" means the template is deprecated. Alternatively, the template could have a function IsDeprecated?
| @@ -873,6 +873,241 @@ func TestTemplates(t *testing.T) { | |||
| require.Equal(t, tmpl.OrganizationName, org2.Name, "organization name on template") | |||
| } | |||
| }) | |||
|
|
|||
| t.Run("ListEmpty", func(t *testing.T) { | |||
There was a problem hiding this comment.
can this new set of tests be table driven?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies the behaviour of the "list templates" API endpoints to return non-deprecated templates by default. Users can still query for deprecated templates by specifying the
deprecated=truequery parameter.Note: The deprecation feature is an enterprise-level feature
Affected Endpoints
Fixes #17565