Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: tune postgres CI tests #17756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Conversation

hugodutka
Copy link
Contributor

@hugodutka hugodutka commented May 11, 2025

Changes:

  • use a bigger runner for test-go-pg on Linux
  • use a depot runner to run postgres tests on Windows
  • use the same Windows ramdisk action for postgres tests as the one currently used for in-memory tests
  • put GOTMPDIR on a ramdisk on Windows
  • tune the number of tests running in parallel on macOS and Windows
  • use a ramdisk for postgres on macOS
  • turn off Spotlight indexing on macOS
  • rerun failing tests to stop flakes from disrupting developers

Results:

This PR helps unblock #15109.

@hugodutka hugodutka changed the title chore: tune postgres CI tests on macOS and Windows chore: tune postgres CI tests May 11, 2025
@hugodutka hugodutka force-pushed the hugodutka/ci-windows-macos-tuning branch 2 times, most recently from df428bc to 0259ec5 Compare May 12, 2025 07:42
@hugodutka hugodutka requested a review from deansheather May 12, 2025 08:23
@hugodutka hugodutka marked this pull request as ready for review May 12, 2025 08:23
@@ -12,8 +12,7 @@ permissions:

jobs:
test-go-pg:
runs-on: ${{ matrix.os == 'macos-latest' && github.repository_owner == 'coder' && 'depot-macos-latest' || matrix.os == 'windows-2022' && github.repository_owner == 'coder' && 'windows-latest-16-cores' || matrix.os }}
if: github.ref == 'refs/heads/main'
runs-on: ${{ matrix.os == 'macos-latest' && github.repository_owner == 'coder' && 'depot-macos-latest' || matrix.os == 'windows-2022' && github.repository_owner == 'coder' && 'depot-windows-2022-16' || matrix.os }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here about the constants you have below for parallelism? It'd be easy for these to go out of sync.

@hugodutka hugodutka force-pushed the hugodutka/ci-windows-macos-tuning branch from 0259ec5 to 8ba05ea Compare May 12, 2025 15:25
@hugodutka hugodutka merged commit ea2cae0 into main May 12, 2025
32 checks passed
@hugodutka hugodutka deleted the hugodutka/ci-windows-macos-tuning branch May 12, 2025 15:38
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants