feat: add is_prebuild_claim to distinguish post-claim provisioning - #17757
Merged
Conversation
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
SasSwart
approved these changes
May 12, 2025
spikecurtis
approved these changes
May 12, 2025
spikecurtis
left a comment
Contributor
There was a problem hiding this comment.
I've suggested a different name for the field, but I don't need to review again.
| string running_workspace_agent_token = 21; | ||
| bool is_prebuild = 20; // Indicates that a prebuilt workspace is being built. | ||
| string running_workspace_agent_token = 21; // Preserves the running agent token of a prebuilt workspace so it can reinitialize. | ||
| bool is_prebuild_claim = 22; // Indicates that a prebuilt workspace is being claimed. |
Contributor
There was a problem hiding this comment.
Suggested change
| bool is_prebuild_claim = 22; // Indicates that a prebuilt workspace is being claimed. | |
| bool claims_prebuilt_workspace = 22; // Indicates that a prebuilt workspace is being claimed. |
Contributor
Author
There was a problem hiding this comment.
You're right; I probably shouldn't refer to "prebuild" here.
I'll make it is_prebuilt_workspace_claim to be similar in form to is_prebuild, since they're related fields.
Contributor
There was a problem hiding this comment.
You could make them a single enum...
Contributor
Author
There was a problem hiding this comment.
Could work, lemme try it and see how it feels.
Contributor
Author
There was a problem hiding this comment.
@spikecurtis great suggestion, this is more in line with how we do other things like workspace transitions; should've done this from the beginning.
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used in combination with coder/terraform-provider-coder#396
This is required by both #17475 and #17571
Operators may need to conditionalize their templates to perform certain operations once a prebuilt workspace has been claimed. This value will only be set once a claim takes place and a subsequent
terraform applyoccurs. Anyterraform applyruns thereafter will be indistinguishable from a normal run on a workspace.